Repository navigation
Select the diffSimulationResults tube - #422
Merged
Merged
Conversation
OpenModelica #14590 asks whether the CI must compare like csv-compare, whose rectangle tube is what MSL and MAP-Lib use. To measure what that changes, a pull request run must be able to verify with another tube. - testmodel.py: when the configuration has a reference_tube, pass tube=OpenModelica.Scripting.TubeAlgorithm.<reference_tube> to diffSimulationResults. Without it the call is the same as before, so the nightly omc still works. - test.py: --reference_tube sets reference_tube for every library, and the report names the tube. A run with it has another confighash. - .CI/Jenkinsfile: pull_request_tube sets --reference_tube. pull_request_verifier=pull request runs OMPython with the omc built from the pull request instead of /usr, because the nightly of the testing image does not know the tube argument yet. Other runs keep /usr. - README.md: document reference_tube. Needs the OpenModelica pull request that adds the tube argument. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenModelica/OpenModelica#14590 asks whether the CI must compare like csv-compare, whose rectangle tube is what MSL and MAP-Lib use. To measure what that changes, a pull request run must be able to verify with another tube.
Needs the OpenModelica pull request that adds the tube argument.
Assisted-by: Claude Opus 5.5